Modern style: Fix prop_subsection_stylebox color not scaling with luminance#112443
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Nov 5, 2025
Merged
Conversation
DeeJayLSP
force-pushed
the
better-modern-subsection-color
branch
from
af74825 to
d433118
Compare
DeeJayLSP
changed the title
prop_subsection_color not scaling with luminanceprop_subsection_stylebox color not scaling with luminance
DeeJayLSP
force-pushed
the
better-modern-subsection-color
branch
from
d433118 to
2856935
Compare
Member
|
Does this PR affect the look substantially when the "Classic" theme is used? |
DeeJayLSP
force-pushed
the
better-modern-subsection-color
branch
from
2856935 to
bbfd2be
Compare
Contributor
Author
Oops, I should have mentioned this doesn't touch the Classic theme. |
DeeJayLSP
changed the title
prop_subsection_stylebox color not scaling with luminanceprop_subsection_stylebox color not scaling with luminance
YeldhamDev
approved these changes
Nov 5, 2025
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The color was calculated wrongly due to being based on the Classic style.
It remains too dark if the editor main color is increased before this change, when it should be a highlight.
#252525#7f7f7f