Allow to add padding to ScrollBars#112441
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Nov 14, 2025
Merged
Conversation
passivestar
approved these changes
Nov 7, 2025
Contributor
passivestar
left a comment
passivestar
left a comment
There was a problem hiding this comment.
Tested, works as expected. Not sure about the UX of setting horizontal and vertical paddings in different places but I guess it can be changed in godot 5 if there's no other way
KoBeWi
reviewed
Nov 11, 2025
KoBeWi
reviewed
Nov 11, 2025
YeldhamDev
force-pushed
the
scrollbar_padding
branch
from
5176e8b to
23a4cff
Compare
Member
Author
|
Changes made. |
KoBeWi
approved these changes
Nov 11, 2025
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(A comparison between the default scrollbar and one with left/right padding plus top/bottom content margins in the
scrolltheme element)This PR adds a set of
padding_*theme constants with all four directions, with the horizontal ones being used forVScrollBar, and the vertical ones forHScrollBar.This inversely mirrors the behavior of the content margins in the
scrolltheme element, where the horizontal margins are present inHScrollBar, and the vertical ones in are inVScrollBar.Helps address #112296 (comment).
Because that would result in a compatibility break, as some users make use of them to increase the minimum size. Even the Godot editor and the default project theme make use of them for that.