X Tutup
Skip to content

Fix compile error with android export plugin#112398

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
LanzaSchneider:patch-5
Nov 6, 2025
Merged

Fix compile error with android export plugin#112398
Repiteo merged 1 commit intogodotengine:masterfrom
LanzaSchneider:patch-5

Conversation

@LanzaSchneider
Copy link
Contributor

@LanzaSchneider LanzaSchneider commented Nov 5, 2025

Due to the absence of the necessary header files included, this compilation error occurs:
{67FDE768-5B59-40E4-A034-997C3F61201A}

@LanzaSchneider LanzaSchneider requested a review from a team as a code owner November 5, 2025 01:56
@Alex2782
Copy link
Member

Alex2782 commented Nov 5, 2025

Compiler errors are usually detected during the pull request process.

How did you run scons, or how did you attempt to compile?

@bruvzg
Copy link
Member

bruvzg commented Nov 5, 2025

Issue seems to be reproducible in editor build with deprecated=no, which is not covered by CI (only build minimal template with deprecated=no). Without it set, it is included via godot_plugin_config.h.

@akien-mga
Copy link
Member

Aside from the style issue, the fix seems correct.

@LanzaSchneider
Copy link
Contributor Author

@akien-mga Thank you for the detailed explanation of the CI failure :-)

Copy link
Member

@syntaxerror247 syntaxerror247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Repiteo
Copy link
Contributor

Repiteo commented Nov 5, 2025

Could you squash your commits? See our pull request guidelines for more information

@LanzaSchneider
Copy link
Contributor Author

@Repiteo Thanks for the reminder—time-zone lag on my side. Now squashed and CI is green.

@Repiteo Repiteo merged commit 0cad83f into godotengine:master Nov 6, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 6, 2025

Thanks!

@LanzaSchneider LanzaSchneider deleted the patch-5 branch November 6, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build fails at 100% with deprecated=no and production=yes

8 participants

X Tutup