X Tutup
Skip to content

Make utterance_id 64-bit.#112379

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
bruvzg:tts64id
Nov 14, 2025
Merged

Make utterance_id 64-bit.#112379
Repiteo merged 1 commit intogodotengine:masterfrom
bruvzg:tts64id

Conversation

@bruvzg
Copy link
Member

@bruvzg bruvzg commented Nov 4, 2025

Fixes #112346

TODO:

  • Test on Android and Web (since both pass IDs to the Java/JS part).

@bruvzg bruvzg marked this pull request as ready for review November 7, 2025 08:26
@bruvzg bruvzg requested review from a team as code owners November 7, 2025 08:26
@bruvzg
Copy link
Member Author

bruvzg commented Nov 7, 2025

I do not think this breaks binary compatibility, both GDExtension and C# already use 64-bit ints, so nothing except metadata is changed.

@Repiteo Repiteo merged commit e46c2ea into godotengine:master Nov 14, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 14, 2025

Thanks!

@raulsntos
Copy link
Member

I do not think this breaks binary compatibility, both GDExtension and C# already use 64-bit ints, so nothing except metadata is changed.

@bruvzg I'm not sure what you mean by C# already using 64-bit ints. Changing the int type breaks binary compatibility in C#. I added a compatibility method in #112798

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Godot signed 64 bit integer becomes signed 32 bit integer for utterance_id in DisplayServer.tts_speak

5 participants

X Tutup