PopupMenu: Fix minimum size for items with icons#112377
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Nov 6, 2025
Merged
PopupMenu: Fix minimum size for items with icons#112377Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
timothyqiu
force-pushed
the
popup-menu-minsize
branch
from
1e7411c to
02ce56e
Compare
timothyqiu
force-pushed
the
popup-menu-minsize
branch
from
02ce56e to
7a3093c
Compare
bruvzg
approved these changes
Nov 6, 2025
Member
bruvzg
left a comment
bruvzg
left a comment
There was a problem hiding this comment.
Seems to be working as expected:
| Before | After |
|---|---|
 |
 |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when there are items with icons,
PopupMenu's minimum width is oneh_separationnarrower than drawn. This isn't that noticeable, becauseh_separationis relatively small andPopupMenutypically has larger paddings introduced by the scrollbar and the background stylebox.This PR also did a bit clean-up as the code for calculating the minimum size has a few unnecessary complexity, probably due to continuous evolution.
Run this test project and click the Popup button: test-4.zip