X Tutup
Skip to content

GDExtension: Add missing method flag#112351

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
charjr:fix-array-remove-at
Nov 4, 2025
Merged

GDExtension: Add missing method flag#112351
Repiteo merged 1 commit intogodotengine:masterfrom
charjr:fix-array-remove-at

Conversation

@charjr
Copy link
Contributor

@charjr charjr commented Nov 3, 2025

Close #112102

Add GDEXTENSION_METHOD_FLAG_VIRTUAL_REQUIRED to GDExtension method flags.

I've made the value identical to METHOD_FLAG_VIRTUAL_REQUIRED as it seems the GDExtension method flags mirror these.

@charjr charjr requested a review from a team as a code owner November 3, 2025 20:33
@AThousandShips AThousandShips added this to the 4.6 milestone Nov 3, 2025
@AThousandShips
Copy link
Member

Your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info.

@charjr
Copy link
Contributor Author

charjr commented Nov 3, 2025

Your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info.

Ah, should be a simple fix, I'll sort it in the next 24 hours.

Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This change looks good to me :-)

@charjr charjr force-pushed the fix-array-remove-at branch from 6f3932e to c342ce4 Compare November 4, 2025 18:40
@charjr
Copy link
Contributor Author

charjr commented Nov 4, 2025

@AThousandShips It is now linked to my account, thank you for spotting that.

Add GDEXTENSION_METHOD_FLAG_VIRTUAL_REQUIRED
@charjr
Copy link
Contributor Author

charjr commented Nov 4, 2025

@dsnopek I'd just like to point out there is one other missing flag:

METHOD_FLAG_OBJECT_CORE = 64,

I left it out since it didn't sound useful to extensions. If it is let me know and I'll add it at the same time.

@dsnopek
Copy link
Contributor

dsnopek commented Nov 4, 2025

The note on that one in the docs says:

Used internally. Allows to not dump core virtual methods (such as [method Object._notification]) to the JSON API.

So, it sounds like any method that it's used on wouldn't be exposed to GDExtension, so I don't think we need it

@Repiteo Repiteo merged commit d845f09 into godotengine:master Nov 4, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 4, 2025

Thanks! Congratulations on your first merged contribution! 🎉

@charjr charjr deleted the fix-array-remove-at branch November 5, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GDExtension interface: Add is_abstract to GDExtensionClassMethodInfo

4 participants

X Tutup