Fix crash for classes without an icon#112339
Conversation
|
Ran into this just now. This does fix the issue for me. Happend when Ctrl + clicking on |
editor/doc/editor_help.cpp
Outdated
| void EditorHelp::_add_type_icon(const String &p_type, int p_size, const String &p_fallback) { | ||
| Ref<Texture2D> icon = EditorNode::get_singleton()->get_class_icon(p_type, p_fallback); | ||
| if (icon.is_null()) { | ||
| return; |
There was a problem hiding this comment.
| return; | |
| icon = EditorNode::get_singleton()->get_class_icon("Object"); | |
| ERR_FAIL_NULL(icon); |
To match behavior to be the as before the change that introduced the crash (fallback to default Object "cube" icon).
There was a problem hiding this comment.
It should be ERR_FAIL_COND(icon.is_null()); in this case, you can't use ERR_FAIL_NULL here
There was a problem hiding this comment.
Not having an icon will leave an empty space (two spaces around the missing icon), so having it will make help page look more consistent.
There was a problem hiding this comment.
The crash is caused by @GDScript and @GlobalScope lacking an icon. Therefore, if we want to handle this error at this stage, we have two options: either implement special handling for these internal names, or assign them a fallback icon.
There was a problem hiding this comment.
I agree that we should fallback to Object again, like before. I'll amend this so we can merge for 4.6-dev3.
bruvzg
left a comment
bruvzg
left a comment
There was a problem hiding this comment.
Since there's no consensus about the icon, it's fine to keep it as is, since it is fixing the crash. We can decide which icon to use/not use later.
akien-mga
force-pushed
the
fix_no_icon_class
branch
from
64b0f61 to
8a6d044
Compare
|
Thanks! |
6 participants
Fixes #112304
The editor would crash due to a null pointer dereference in EditorHelp::_add_type_icon when trying to display the help page for a class that does not have a registered icon (e.g., internal types like
@GlobalScope).This PR adds null check to
EditorHelp::_add_type_icon