GDExtension: Add system for builtin method compatibility#112290
Merged
Repiteo merged 2 commits intogodotengine:masterfrom Nov 5, 2025
Merged
GDExtension: Add system for builtin method compatibility#112290Repiteo merged 2 commits intogodotengine:masterfrom
Repiteo merged 2 commits intogodotengine:masterfrom
Conversation
dsnopek
force-pushed
the
variant-call-compat-methods
branch
from
52490b0 to
1b76718
Compare
dsnopek
force-pushed
the
variant-call-compat-methods
branch
2 times, most recently
from
d666f67 to
75731f8
Compare
aaronfranke
approved these changes
Nov 3, 2025
Member
aaronfranke
left a comment
aaronfranke
left a comment
There was a problem hiding this comment.
Most of the details here are beyond my expertise, but suffice to say, so long as it works, I'm happy with it!
AThousandShips
approved these changes
Nov 3, 2025
Member
AThousandShips
left a comment
AThousandShips
left a comment
There was a problem hiding this comment.
Code and cases look good to me
dsnopek
force-pushed
the
variant-call-compat-methods
branch
from
75731f8 to
1e12993
Compare
Ivorforce
approved these changes
Nov 3, 2025
Repiteo
approved these changes
Nov 4, 2025
Contributor
Repiteo
left a comment
Repiteo
left a comment
There was a problem hiding this comment.
Looks great! Just needs a rebase and it'll be good to go!
Co-authored-by: Aaron Franke <arnfranke@yahoo.com>
dsnopek
force-pushed
the
variant-call-compat-methods
branch
from
1e12993 to
bc9f3c7
Compare
Contributor
Author
|
Rebased! |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Up until now, we haven't had any way to register compatibility methods for builtin methods, which has meant that we couldn't change their signature.
This has blocked moving forward on a number of issues, including #79140
This PR adds such a system!
In order to test it, I've also implemented the main change from #79140 in the 2nd commit.
cc @aaronfranke
Supersedes #79140