Fix GraphEdit contrast in modern theme#112260
Conversation
akien-mga
changed the title
|
That reminds me, I'm curious as to whether GraphNodes should be darker or lighter than the background. If we want to follow the concept of UI elevation (example), more prominent elements should have a brighter background (on both dark and light themes). |
|
I think lighter nodes might look better but that would probably be a much bigger PR because I'd need to make sure that it still works well with the inner elements of the nodes. This PR on the other hand is just a simple bugfix |
|
Blender has darker background and lighter nodes: 
Same for Unity Engine: 
Perhaps something like this, but lighter: 
|
Calinou
left a comment
Calinou
left a comment
There was a problem hiding this comment.
Tested locally, it works as expected. I can confirm the focus indicator issue is fixed too.
Code looks good to me.
Before
| Default | Light | Black (OLED) |
|---|---|---|
 |
 |
 |
After
| Default | Light | Black (OLED) |
|---|---|---|
 |
 |
 |
|
Thanks! |
4 participants
Fixes the lack of contrast between graph nodes and their background in the new theme. This PR makes the values close to what they are in the classic theme
Didn't screenshot the light theme but tested it and made it match the classic theme values too.
While I was at it I also fixed focus indication for GraphEdit, it was solving a problem that doesn't exist anymore after the theme was ported from gdscript