Fix drawing of slot icons in GraphNode when slots are not continuous#112245
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Nov 1, 2025
Merged
Fix drawing of slot icons in GraphNode when slots are not continuous#112245akien-mga merged 1 commit intogodotengine:masterfrom
GraphNode when slots are not continuous#112245akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
AThousandShips
added
bug
topic:gui
cherrypick:4.5
detomon
commented
Oct 31, 2025
Comment on lines
686
to
694
| if (slot.draw_stylebox) { | ||
| Control *child = Object::cast_to<Control>(get_child(E.key, false)); | ||
| if (!child || !child->is_visible_in_tree()) { | ||
| continue; | ||
| Control *child = Object::cast_to<Control>(get_child(slot_index, false)); | ||
| if (child && child->is_visible_in_tree()) { | ||
| Rect2 child_rect = child->get_rect(); | ||
| child_rect.position.x = sb_panel->get_margin(SIDE_LEFT); | ||
| child_rect.size.width = width; | ||
| draw_style_box(sb_slot, child_rect); | ||
| } | ||
| Rect2 child_rect = child->get_rect(); | ||
| child_rect.position.x = sb_panel->get_margin(SIDE_LEFT); | ||
| child_rect.size.width = width; | ||
| draw_style_box(sb_slot, child_rect); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I rearranged this part to remove the continue, which may lead to code being skipped below this block by accident (if something is added below in the future).
Member
|
Thanks! |
Member
|
Cherry-picked for 4.5.2. |
akien-mga
removed
the
cherrypick:4.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #107298