Modern style: switch to classic renderer name colors#112242
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Nov 1, 2025
Merged
Modern style: switch to classic renderer name colors#112242akien-mga merged 1 commit intogodotengine:masterfrom
akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
YeldhamDev
approved these changes
Oct 31, 2025
Member
|
|
DeeJayLSP
force-pushed
the
rend-swap-fix
branch
from
31a59de to
768991f
Compare
Contributor
Author
|
Modified to hex on Modern, so it matches with Classic without a diff bigger than it needs to be. |
Mickeon
approved these changes
Oct 31, 2025
Member
Mickeon
left a comment
Mickeon
left a comment
There was a problem hiding this comment.
🤷 about the hex thing, it doesn't matter right now probably.
Calinou
approved these changes
Oct 31, 2025
Member
Calinou
left a comment
Calinou
left a comment
There was a problem hiding this comment.
Code looks good to me.
IIRC, there's no difference in binary size between Color::hex() and Color(r, g, b, a). The only form we want to avoid is Color("hex_string") as it's slower and takes up more space in the binary.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #112234.
Just copy-pasted from Classic to Modern.