OpenXR: Fix resizing viewports used by OpenXRCompositionLayer#112227
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 31, 2025
Merged
Conversation
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if you change the size of a
SubViewportthat is being used by anOpenXRCompositionLayerit will break.This PR fixes that!
The changes in the OpenGL renderer actually aren't needed to fix the bug (only the Vulkan changes), but after making the Vulkan changes, I checked if OpenGL had similar issues, and it does, but only for changing the MSAA and HDR flags - it already has the correct check when changing the render target size.