Fix error spam when dragging text in the script editor.#112190
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 30, 2025
Merged
Fix error spam when dragging text in the script editor.#112190Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
AThousandShips
approved these changes
Oct 30, 2025
Repiteo
approved these changes
Oct 30, 2025
Contributor
|
Thanks! |
KoBeWi
reviewed
Oct 30, 2025
|
|
||
| bool EditorPropertyNodePath::is_drop_valid(const Dictionary &p_drag_data) const { | ||
| if (p_drag_data["type"] != "nodes") { | ||
| if (!p_drag_data.has("type") || p_drag_data["type"] != "nodes") { |
Member
There was a problem hiding this comment.
Uh late for review, but this should be
Suggested change
| if (!p_drag_data.has("type") || p_drag_data["type"] != "nodes") { | |
| if (p_drag_data.get("type", "") != "nodes") { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Bug: Dictionary::operator[] used when there was no value for the given key, please report.error spam when dragging text in the script editor.