Track groups in Animation tab hover highlight#112148
Track groups in Animation tab hover highlight#112148Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
|
Also made a PR for this (didn't have time to push it), one thing I was thinking about: Currently you can only select the node by clicking on the name part of the timeline and not the full row. Would probably feel strange if the hover state was showing for the full row. |
This is a good point, I see what you mean about it feeling strange. IMO, reducing the hover state to only show when over the portion with text is better like you did. I think it's equally valid to make the full row clickable for the sake of discoverability. I'm not sure which would be better. |
|
I think reducing hover area is better. The sections are clearly separated, so it makes that only node part is clickable. It's also less visual noise. |
21dba94 to
dd14954
Compare
I believe I fixed the behavior. I checked different themes as well and they looked good to me. example.mp4 |
dd14954 to
b71da67
Compare
|
Is anything more needed on my end to get this merged? I'm happy to make any necessary fixes, please let me know if I am missing anything. Thank you!! |
Co-authored-by: Silc Lizard (Tokage) Renew <tokage.it.lab@gmail.com> Co-authored-by: Tomasz Chabora <kobewi4e@gmail.com>
9d31d06 to
472c8df
Compare
|
I squashed all commits and rebased. Thank you again everyone for the feedback. Please let me know if I can do anything else related to this PR. I'm happy to help! |
|
Thanks! Congratulations on your first merged contribution! 🎉 |
Fixes: #112065
This fixes a usability bug in the Animation tab,. The track groups did not have a hover style, despite being clickable.