X Tutup
Skip to content

Track groups in Animation tab hover highlight#112148

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
carterwilson1337:master
Nov 14, 2025
Merged

Track groups in Animation tab hover highlight#112148
Repiteo merged 1 commit intogodotengine:masterfrom
carterwilson1337:master

Conversation

@carterwilson1337
Copy link
Contributor

Fixes: #112065

This fixes a usability bug in the Animation tab,. The track groups did not have a hover style, despite being clickable.

@Giganzo
Copy link
Contributor

Giganzo commented Oct 30, 2025

Also made a PR for this (didn't have time to push it), one thing I was thinking about:

Currently you can only select the node by clicking on the name part of the timeline and not the full row. Would probably feel strange if the hover state was showing for the full row.
So what I did was making the hover state only show when mouse was over this area. Either that or make the full row clickable. What would be best?

@carterwilson1337
Copy link
Contributor Author

Also made a PR for this (didn't have time to push it), one thing I was thinking about:

Currently you can only select the node by clicking on the name part of the timeline and not the full row. Would probably feel strange if the hover state was showing for the full row. So what I did was making the hover state only show when mouse was over this area. Either that or make the full row clickable. What would be best?

This is a good point, I see what you mean about it feeling strange. IMO, reducing the hover state to only show when over the portion with text is better like you did. I think it's equally valid to make the full row clickable for the sake of discoverability. I'm not sure which would be better.

@KoBeWi
Copy link
Member

KoBeWi commented Oct 31, 2025

I think reducing hover area is better. The sections are clearly separated, so it makes that only node part is clickable. It's also less visual noise.
Also the hover style needs to be changed. It should be highlight over the selected section, not a general outline.

@carterwilson1337
Copy link
Contributor Author

I think reducing hover area is better. The sections are clearly separated, so it makes that only node part is clickable. It's also less visual noise. Also the hover style needs to be changed. It should be highlight over the selected section, not a general outline.

I believe I fixed the behavior. I checked different themes as well and they looked good to me.

example.mp4

Thank you @Giganzo and @KoBeWi for the feedback.

@carterwilson1337
Copy link
Contributor Author

Is anything more needed on my end to get this merged? I'm happy to make any necessary fixes, please let me know if I am missing anything. Thank you!!

Co-authored-by: Silc Lizard (Tokage) Renew <tokage.it.lab@gmail.com>

Co-authored-by: Tomasz Chabora <kobewi4e@gmail.com>
@carterwilson1337
Copy link
Contributor Author

I squashed all commits and rebased. Thank you again everyone for the feedback. Please let me know if I can do anything else related to this PR. I'm happy to help!

@Repiteo Repiteo merged commit ba44671 into godotengine:master Nov 14, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 14, 2025

Thanks! Congratulations on your first merged contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Track groups in Animation tab are missing hover highlight

6 participants

X Tutup