2D: Fix incorrect 2D rendering#112131
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 29, 2025
Merged
Conversation
Regression from godotengine#111183 Closes godotengine#112121
Member
|
Will give this a test tomorrow! |
Calinou
approved these changes
Oct 28, 2025
Member
Calinou
left a comment
Calinou
left a comment
There was a problem hiding this comment.
Tested locally on Linux + GCC + NVIDIA, it works as expected. Code looks good to me.
(I could reproduce the original issue on master with the same compiler configuration.)
clayjohn
approved these changes
Oct 28, 2025
AThousandShips
approved these changes
Oct 29, 2025
Member
AThousandShips
left a comment
AThousandShips
left a comment
There was a problem hiding this comment.
Didn't test the mingw build but can confirm it fixes the Label, thank you for a quick fix!
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The template instance was modifying the texture parameters and those were carrying forward to other types. I was able to reproduce the issue and confirm it matched the expected output from #112121
Regression from #111183
Closes #112121