LSP: Fix remaining unsafe dict access#112128
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 29, 2025
Merged
Conversation
AThousandShips
changed the title
fstxz
approved these changes
Oct 28, 2025
Contributor
fstxz
left a comment
fstxz
left a comment
There was a problem hiding this comment.
Tested locally, this fixes the issue.
Ivorforce
approved these changes
Oct 28, 2025
AThousandShips
approved these changes
Oct 29, 2025
Contributor
|
Thanks! |
This was referenced Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #112099
I did check all dictionary access against the spec and this should be all remaining unsave access problems in the LSP code. Everything else is either required by the spec or protected by contracts from the spec.