[Windows] Use separate resource files for export templates.#112116
[Windows] Use separate resource files for export templates.#112116akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
|
For the reference, missing values are shown as empty string in Windows UI. And |
| VALUE "FileDescription", GODOT_VERSION_NAME | ||
| VALUE "FileVersion", GODOT_VERSION_NUMBER |
There was a problem hiding this comment.
Maybe we should create EngineDescription and EngineVersion instead?
So users keep File* for their own project's metadata, but we keep a reference to Godot.
Likewise, would there be other values we want to keep with some Engine prefix?
There was a problem hiding this comment.
Though IIUC you said that when resource modification is enabled, we don't reuse any of this and write it manually, so if we want this we'd have to add it to the export code too I suppose.
There was a problem hiding this comment.
Non-standard fields will be invisible in UI. And yes, all are overwritten by exporter. So I left these only to make specific template version easy to identify (before export, when using custom templates).
|
Thanks! |
2 participants
Only keeping bare minimum info in the templates, since it is intended to be overwritten by exporter in any case.
Fixes #106034 and allows future customization (if we want to use default project icon for example).