X Tutup
Skip to content

Improve error message when _EDITOR_GET fails#112069

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
timothyqiu:editor-get-complains
Oct 27, 2025
Merged

Improve error message when _EDITOR_GET fails#112069
Repiteo merged 1 commit intogodotengine:masterfrom
timothyqiu:editor-get-complains

Conversation

@timothyqiu
Copy link
Member

Recently, I encountered the following error while running a custom build:

ERROR: Condition "!EditorSettings::get_singleton() || !EditorSettings::get_singleton()->has_setting(p_setting)" is true. Returning: Variant()
   at: _EDITOR_GET (editor/settings/editor_settings.cpp:1517)

It's frustrating that the value of p_setting is not shown.

This PR changes the error to something like this:

ERROR: Editor setting "name/of/the_missing_setting" does not exist.
   at: _EDITOR_GET (editor/settings/editor_settings.cpp:1518)

@timothyqiu timothyqiu requested a review from a team October 27, 2025 01:51
@bruvzg bruvzg added this to the 4.6 milestone Oct 27, 2025
@Ivorforce Ivorforce requested a review from a team October 27, 2025 08:57
@Repiteo Repiteo merged commit 8c7f289 into godotengine:master Oct 27, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 27, 2025

Thanks!

@timothyqiu timothyqiu deleted the editor-get-complains branch October 27, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

X Tutup