X Tutup
Skip to content

Fix FindInFiles crash when changing language#111934

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
KoBeWi:crash_in_files
Oct 23, 2025
Merged

Fix FindInFiles crash when changing language#111934
Repiteo merged 1 commit intogodotengine:masterfrom
KoBeWi:crash_in_files

Conversation

@KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Oct 22, 2025

  1. Search something using Find in Files dialog.
  2. Delete all results using X buttons.
  3. Change editor language via editor settings.

FindInFiles assumes that root TreeItem always exists, but deleting results could delete it.

@KoBeWi KoBeWi added this to the 4.6 milestone Oct 22, 2025
@KoBeWi KoBeWi requested a review from a team as a code owner October 22, 2025 21:00
Copy link
Contributor

@kitbdev kitbdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, fixes the crash.

@Repiteo Repiteo merged commit add458d into godotengine:master Oct 23, 2025
19 of 20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 23, 2025

Thanks!

@KoBeWi KoBeWi deleted the crash_in_files branch October 23, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup