Fix incorrect failure code in screen_get_framebuffer_format#111883
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 21, 2025
Merged
Fix incorrect failure code in screen_get_framebuffer_format#111883Repiteo merged 1 commit intogodotengine:masterfrom
screen_get_framebuffer_format#111883Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
RenderingDevice::screen_get_framebuffer_format should return a value of type RenderingDevice::FramebufferFormatID which is an alias of int64_t but it returns Error::FAILED with a value of 1. The compiler does not complain because both types are integers but 1 corresponds to a valid FramebufferFormatID, meaning a certain failure condition is missed. This commit changes it to the correct value, INVALID_ID.
AThousandShips
approved these changes
Oct 21, 2025
Member
AThousandShips
left a comment
AThousandShips
left a comment
There was a problem hiding this comment.
From context this seems correct, probably a simple copy/paste error
clayjohn
approved these changes
Oct 21, 2025
Contributor
|
Thanks! |
akien-mga
changed the title
screen_get_framebuffer_format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RenderingDevice::screen_get_framebuffer_formatshould return a value of typeRenderingDevice::FramebufferFormatIDwhich is an alias ofint64_tbut it returnsError::FAILEDwhich has a value of 1. The compiler does not complain because both types are integers but 1 corresponds to a validFramebufferFormatID, meaning a certain failure condition is missed.This commit changes it to the correct value,
INVALID_ID.