X Tutup
Skip to content

Fix IME input in multiple windows at once#111865

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
kitbdev:fix-multiple-ime
Oct 21, 2025
Merged

Fix IME input in multiple windows at once#111865
Repiteo merged 1 commit intogodotengine:masterfrom
kitbdev:fix-multiple-ime

Conversation

@kitbdev
Copy link
Contributor

@kitbdev kitbdev commented Oct 21, 2025

Events that stop the IME (when text is empty) are still needed even if window isn't focused.

@kitbdev kitbdev added this to the 4.6 milestone Oct 21, 2025
@kitbdev kitbdev added the bug label Oct 21, 2025
@kitbdev kitbdev requested a review from a team as a code owner October 21, 2025 00:46
@kitbdev kitbdev added topic:gui cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release labels Oct 21, 2025
@bruvzg bruvzg self-requested a review October 21, 2025 04:50
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is reproducible on macOS and the fix seems to be working as expected.

I guess it was not noticed earlier since it's only reproducible under specific set of conditions, there's already control focus check, so you need to open a sub-window without taking focus from the control (e.g., find in files in the editor opened using keyboard shortcut).

@Repiteo Repiteo merged commit ee6fb9e into godotengine:master Oct 21, 2025
39 of 40 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 21, 2025

Thanks!

@kitbdev kitbdev deleted the fix-multiple-ime branch October 21, 2025 20:09
@akien-mga akien-mga removed the cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release label Jan 16, 2026
@akien-mga
Copy link
Member

Cherry-picked for 4.5.2.

@akien-mga akien-mga removed the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Jan 16, 2026
@akien-mga akien-mga changed the title Fix IME input in multiple Windows at once Fix IME input in multiple windows at once Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IME text is shown in multiple windows at once.

4 participants

X Tutup