Round values after renormalization when generating mipmaps.#111841
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 20, 2025
Merged
Round values after renormalization when generating mipmaps.#111841Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
blueskythlikesclouds
force-pushed
the
mipmap-normalize-fix
branch
from
1e51bd4 to
3d4f248
Compare
BlueCube3310
approved these changes
Oct 20, 2025
clayjohn
approved these changes
Oct 20, 2025
Contributor
|
Thanks! |
akien-mga
added
the
cherrypick:4.5
Member
|
Cherry-picked for 4.5.2. |
akien-mga
removed
the
cherrypick:4.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents flat regions of normal maps from progressively getting darker, and causing the normal to distort by distance as a result.
For example, when the pixel value is [128, 128, 255], the renormalization makes it [127.999~, 127.999~, 254.999~], which gets floored to [127, 127, 254]. When that also gets normalized, the X and Y become 126.996~, and it progressively gets smaller with each mip level, which causes distortion. Rounding fixes this.
Test scene is from here.