X Tutup
Skip to content

Fix crash when operating on newly created font RIDs#111810

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
timothyqiu:ts-null-data
Oct 20, 2025
Merged

Fix crash when operating on newly created font RIDs#111810
Repiteo merged 1 commit intogodotengine:masterfrom
timothyqiu:ts-null-data

Conversation

@timothyqiu
Copy link
Member

@timothyqiu timothyqiu commented Oct 19, 2025

data_ptr was not initialized, so null checks won't work as expected.

var ts = TextServerManager.get_primary_interface()
var font = ts.create_font()
print(ts.font_get_name(font))  # Crashes
ts.free_rid(font)

@timothyqiu timothyqiu added the bug label Oct 19, 2025
@timothyqiu timothyqiu requested a review from a team as a code owner October 19, 2025 03:01
@timothyqiu timothyqiu added crash topic:gui cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release labels Oct 19, 2025
@bruvzg bruvzg added this to the 4.6 milestone Oct 19, 2025
@Repiteo Repiteo merged commit 07b3cc7 into godotengine:master Oct 20, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 20, 2025

Thanks!

@timothyqiu timothyqiu deleted the ts-null-data branch October 21, 2025 00:12
@akien-mga
Copy link
Member

akien-mga commented Jan 16, 2026

Cherry-picked for 4.5.2.

@akien-mga akien-mga removed the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bruvzg bruvzg bruvzg approved these changes

Assignees

No one assigned

Labels

bug crash topic:gui

Projects

None yet

Milestone

4.6

Development

Successfully merging this pull request may close these issues.

4 participants

@timothyqiu @Repiteo @akien-mga @bruvzg
X Tutup