Open source code errors in external editor by KoBeWi · Pull Request #111805 · godotengine/godot

KoBeWi · 2025-10-18T22:05:11Z

Errors in the Output are now clickable, but the errors from engine's source code do not open properly. The path includes : (line number) so using shell_open() will always fail.

This PR fixes it, but I went a step further, and made the errors automatically opened in external editor if it's configured.

godot.windows.editor.dev.x86_64_pA1wQuwbXd.mp4

kitbdev

Looks good.
Note that this is only useful for engine developers since you need to compile the engine yourself to get the absolute paths needed, otherwise nothing happens.

Calinou · 2025-10-28T01:13:15Z

Errors use relative paths for C++ stack traces on my Linux system (using debug_symbols=yes), so this won't work there:

This also applies to errors printed to the Output panel.

We could support an editor setting that defines the Godot source code location, so that the path can be resolved. Alternatively, you could try to resolve a path relative to the editor binary location (with ../ prepended).

KoBeWi · 2025-10-28T16:07:21Z

How did you enable relative paths?

Repiteo · 2025-10-28T16:46:07Z

I think that's just a default option for many compilers. It can be explicitly overridden via -fdiagnostics-absolute-paths on clang, for instance

KoBeWi · 2025-10-28T22:01:40Z

It should be fixed now.

editor/editor_log.cpp

Calinou

On Linux, nothing happens when I click the error here:

@tool
extends Node


func _ready() -> void:
	push_error("test")

My settings are set this way, it works for GDScript files:

I restarted the editor after changing the external editor settings, but it didn't help. I don't see anything more being printed to stdout/stderr, even with verbose mode.

KoBeWi · 2025-10-30T17:40:33Z

The relative paths are handled correctly, but the regex fails to match them. I don't even know why is it there.

godot/editor/editor_log.cpp

Lines 203 to 206 in e4c9950

    
           Ref<RegExMatch> uri_match = RegEx(R"(^([a-zA-Z][a-zA-Z0-9+.-]*):(?://)?(.+?)(?::([0-9]+))?$)").search(p_meta); 
        
           if (uri_match.is_null()) { 
        
           	return; 
        
           }

KoBeWi · 2025-10-31T22:13:04Z

@Calinou Please test again.
I removed the regex completely.

editor/script/script_editor_plugin.h

editor/script/script_editor_plugin.cpp

Calinou

Works great now 🙂 Code looks good to me.

Note that I had to replace if (ignore_project) with if (p_ignore_project) to get it to build locally, so you should do that to fix CI.

Repiteo · 2025-11-05T17:52:11Z

Thanks!

GustJc · 2025-11-13T11:25:35Z

I got a bit confused by this feature. I thought it would link to the code inside github at first.
I get that opening the local file is a very useful feature for debugging in dev.
But it might be confusing for people that are using the engine.

Here's what happen: When opening Godot Editor with no dev environment, I clicked the error link, but then it just opened vscode with an empty new file named after the cpp file that gave the error.

This could confuse the engine users to think this is a bug.

So it might be a good idea to link to github instead by default in the release version.
Make it toggleable in the EditorSettings, or check if the file exists and go from there.

Unless I'm missing something?

KoBeWi · 2025-11-13T11:31:10Z

it just opened vscode with an empty new file named after the cpp file that gave the error.

This shouldn't be happening, it's supposed to open the file only if it exists.

So it might be a good idea to link to github instead by default in the release version.

I can try that.

GustJc · 2025-11-18T11:27:58Z

This shouldn't be happening, it's supposed to open the file only if it exists.

Just for reference, here's a video.

link.error.mp4

It only happens because I have vscode setup as the external text editor.
But I don't think it should be happening if it doesn't find the file.

So it might be a good idea to link to github instead by default in the release version.

I can try that.

That would be awesome. Even though I have Godot source here, I often prefer to go to github to browse the code if I'm just trying to understand something simple. It would be very helpful if it did so when the file is not present, or even with an editor setting toggle.

KoBeWi added this to the 4.6 milestone Oct 18, 2025

KoBeWi requested a review from a team as a code owner October 18, 2025 22:05

KoBeWi added the enhancement label Oct 18, 2025

KoBeWi requested a review from a team October 18, 2025 22:05

KoBeWi added the topic:editor label Oct 18, 2025

kitbdev approved these changes Oct 24, 2025

View reviewed changes

KoBeWi force-pushed the open_source_be_like branch 2 times, most recently from d4ec057 to 12de363 Compare October 28, 2025 22:01

Repiteo requested a review from Calinou October 29, 2025 18:04

Calinou reviewed Oct 30, 2025

View reviewed changes

editor/editor_log.cpp Outdated Show resolved Hide resolved

Calinou reviewed Oct 30, 2025

View reviewed changes

KoBeWi mentioned this pull request Oct 31, 2025

Make file part of errors/warnings clickable in Output panel #108473

Merged

KoBeWi force-pushed the open_source_be_like branch from 12de363 to 0c61ff1 Compare October 31, 2025 22:12

akien-mga requested a review from Calinou November 1, 2025 17:34

AThousandShips approved these changes Nov 3, 2025

View reviewed changes

editor/script/script_editor_plugin.h Outdated Show resolved Hide resolved

editor/script/script_editor_plugin.cpp Outdated Show resolved Hide resolved

KoBeWi force-pushed the open_source_be_like branch from 0c61ff1 to 02a0595 Compare November 3, 2025 20:14

Calinou reviewed Nov 4, 2025

View reviewed changes

Open source code errors in external editor

edceae1

KoBeWi force-pushed the open_source_be_like branch from 02a0595 to edceae1 Compare November 4, 2025 23:53

Calinou approved these changes Nov 5, 2025

View reviewed changes

Repiteo merged commit 9d8d6fd into godotengine:master Nov 5, 2025
20 checks passed

KoBeWi deleted the open_source_be_like branch November 5, 2025 17:53

KoBeWi mentioned this pull request Nov 14, 2025

Open missing source file errors on GitHub #112759

Open

Uh oh!

Conversation

KoBeWi commented Oct 18, 2025

Uh oh!

kitbdev left a comment

Choose a reason for hiding this comment

Uh oh!

Calinou commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KoBeWi commented Oct 28, 2025

Uh oh!

Repiteo commented Oct 28, 2025

Uh oh!

KoBeWi commented Oct 28, 2025

Uh oh!

Uh oh!

Calinou left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KoBeWi commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KoBeWi commented Oct 31, 2025

Uh oh!

Uh oh!

Uh oh!

Calinou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Repiteo commented Nov 5, 2025

Uh oh!

GustJc commented Nov 13, 2025

Uh oh!

KoBeWi commented Nov 13, 2025

Uh oh!

GustJc commented Nov 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Calinou commented Oct 28, 2025 •

edited

Loading

Calinou left a comment •

edited

Loading

KoBeWi commented Oct 30, 2025 •

edited

Loading