Make PopupMenu respect max_size#111801
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 27, 2025
Merged
Conversation
AThousandShips
changed the title
PopupMenu respect max_size
bruvzg
reviewed
Oct 27, 2025
scgm0
force-pushed
the
PopupMenu-no-longer-ignores-max_size
branch
from
2b3025b to
4a98162
Compare
bruvzg
approved these changes
Oct 27, 2025
Contributor
|
Thanks! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #111790
Meanwhile, if
wrap_controlsis set to false,PopupMenuwill no longer resetmin_sizeandsize. Given thatPopupdefaultswrap_controlsto true, this change should have minimal impact on existing projects. Users who manually setwrap_controlsto false are expected to manage the size ofPopupMenuthemselves.