X Tutup
Skip to content

Fix not releasing action when actions are erased.#111747

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
zedzee37:input-fix
Dec 12, 2025
Merged

Fix not releasing action when actions are erased.#111747
Repiteo merged 1 commit intogodotengine:masterfrom
zedzee37:input-fix

Conversation

@zedzee37
Copy link
Contributor

Sorry! Did not mean to delete my branch lol.
Fixes: #63734

@zedzee37 zedzee37 requested a review from a team as a code owner October 16, 2025 23:05
@AThousandShips AThousandShips added bug topic:input cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release labels Oct 17, 2025
@AThousandShips AThousandShips added this to the 4.6 milestone Oct 17, 2025
Copy link
Member

@Alex2782 Alex2782 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

You might need to combine your 3 commits into 1 (squash) and perform a rebase.
docs


I ported MRP to Godot 4.6 and tested it with the master branch:
bug_63734.zip

@zedzee37
Copy link
Contributor Author

zedzee37 commented Dec 8, 2025

Noted, I will make sure to do that as soon as possible, thanks!

@Repiteo Repiteo merged commit 31413d5 into godotengine:master Dec 12, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 12, 2025

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 4.5.2.

@Nintorch
Copy link
Contributor

This PR should also fix #111357 (possibly, the same issue as #63734 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Removing an action event with InputMap causes Input.is_action_pressed to return true in some cases

6 participants

X Tutup