Do not begin a new frame during RenderingDevice's shutdown.#111733
Do not begin a new frame during RenderingDevice's shutdown.#111733Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
|
I suspect this is causing some of our sporadic device lost errors. It's obviously extremely difficult to reproduce. But the current behaviour is invalid, so this should be fixed |
|
Thanks! |
Calinou
left a comment
Calinou
left a comment
There was a problem hiding this comment.
Tested locally on macOS 26 (Metal and Vulkan), it works as expected (including lightmap baking). Note that I couldn't reproduce device lost issues on my end previously though.
Code looks good to me.
Ya, it fixes a crash on shutdown. The old behaviour was undefined and caused random issues. It was pretty rare to reproduce though, so we could consider reverting this temporarily while we find a proper fix if I can't find a proper fix soon |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
6 participants
Some APIs do not support destroying a command buffer that was begun but never finalized. The solution here is to just not start a new frame during RenderingDevice's shutdown.