Fix compilation errors when disable_xr=yes#111663
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 15, 2025
Merged
Conversation
AThousandShips
added
the
cherrypick:4.5
dsnopek
approved these changes
Oct 15, 2025
Contributor
dsnopek
left a comment
dsnopek
left a comment
There was a problem hiding this comment.
Thanks! Looks good to me :-)
It appears the build system will set XR to disabled when 3D is disabled, so I think this should still do what it was doing for disable_3d=yes as well
AThousandShips
added
regression
and removed
cherrypick:4.5
Member
|
This was a regression from: Which made this variable unavailable in XR disabled builds This should be the correct solution indeed |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.