X Tutup
Skip to content

GLTF: Determine the component type when encoding object model properties#111613

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
aaronfranke:gltf-obj-model-components
Nov 17, 2025
Merged

GLTF: Determine the component type when encoding object model properties#111613
Repiteo merged 1 commit intogodotengine:masterfrom
aaronfranke:gltf-obj-model-components

Conversation

@aaronfranke
Copy link
Member

@aaronfranke aaronfranke commented Oct 13, 2025

The KHR_animation_pointer specification is very clear:

If the Object Model Data Type is int, the output accessor component type MUST be one of the non-normalized integer types and its values are used as-is.

If the Object Model Data Type is bool, the output accessor component type MUST be unsigned byte; 0 is converted to false, any other value is converted to true.

Currently, Godot is always using single-precision floats when serializing Variant arrays, which means that Godot is generating invalid output when attempting to export an animation using ints or floats. This PR fixes this.

@fire
Copy link
Member

fire commented Nov 13, 2025

Dependencies have been merged.

@aaronfranke aaronfranke marked this pull request as ready for review November 14, 2025 03:05
@aaronfranke aaronfranke requested review from a team as code owners November 14, 2025 03:05
@aaronfranke aaronfranke force-pushed the gltf-obj-model-components branch from abc9cd2 to a90b482 Compare November 14, 2025 03:06
@aaronfranke aaronfranke moved this from Work in progress to Ready for review in Asset Pipeline Issue Triage Nov 14, 2025
@aaronfranke aaronfranke modified the milestones: 4.x, 4.6 Nov 14, 2025
@aaronfranke aaronfranke force-pushed the gltf-obj-model-components branch from a90b482 to e9bfc5a Compare November 15, 2025 02:16
@Repiteo Repiteo merged commit 68410ac into godotengine:master Nov 17, 2025
20 checks passed
@github-project-automation github-project-automation bot moved this from Ready for review to Done in Asset Pipeline Issue Triage Nov 17, 2025
@Repiteo
Copy link
Contributor

Repiteo commented Nov 17, 2025

Thanks!

@aaronfranke aaronfranke deleted the gltf-obj-model-components branch November 17, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup