Fix description of Viewport::set_input_as_handled#111591
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 14, 2025
Merged
Fix description of Viewport::set_input_as_handled#111591Repiteo merged 1 commit intogodotengine:masterfrom
Viewport::set_input_as_handled#111591Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
Mickeon
approved these changes
Oct 13, 2025
Contributor
|
Could you trim the commit message to just the heading? It doesn't need to repeat the PR's description, and linking the issue itself would cause unwanted pings whenever the commit is referenced |
The method stops the `InputEvent` from propagating up, not down.
Contributor
Author
|
Done. |
Contributor
|
Thanks! Congratulations on your first merged contribution! 🎉 |
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The input is propagated bottom-up in the scene tree hierarchy. It's not obvious that it's the case, so let's prove that the nodes are indeed traversed post-order.
In method
SceneTree::_call_input_pausethe nodes to be traversed are ordered usingSceneTree::_update_group_order, which orders the nodes from first to last in tree hierarchy. Then this ordered Vector is traversed in the reverese order.Indeed, the old description was incorrect and it has been fixed. The
set_input_as_handledmethod stops theInputEventfrom propagating up, not down.Fixes #111571.