Apply luminance multiplier in copy_cubemap_to_panorama#111577
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 14, 2025
Merged
Apply luminance multiplier in copy_cubemap_to_panorama#111577Repiteo merged 1 commit intogodotengine:masterfrom
copy_cubemap_to_panorama#111577Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
AThousandShips
added
bug
topic:rendering
topic:3d
cherrypick:4.4
Contributor
|
Can you show the result? |
Contributor
Author
|
@jcostello The mrp is from #94401, all screenshots are taken in mobile, the only difference is which renderer baked the lightmaps. Forward+ |
Kaleb-Reid
force-pushed
the
fix-lightmap-luminance
branch
from
ae13f33 to
8173f43
Compare
clayjohn
approved these changes
Oct 14, 2025
clayjohn
removed
the
cherrypick:4.4
Contributor
|
Thanks! |
akien-mga
changed the title
copy_cubemap_to_panorama
Member
|
Cherry-picked for 4.5.2. |
akien-mga
removed
the
cherrypick:4.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As predicted in the linked issue, it seems that the luminance multiplier needs to be factored in.
The luminance multiplier only affects the panorama copy mode in the shader currently, but I can make it usable for all the modes if need be.
Fixes #94401