Core: Support INF/NAN in JSON from/to native#111522
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 29, 2025
Merged
Core: Support INF/NAN in JSON from/to native#111522Repiteo merged 1 commit intogodotengine:masterfrom
INF/NAN in JSON from/to native#111522Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
aaronfranke
approved these changes
Oct 11, 2025
Member
aaronfranke
left a comment
aaronfranke
left a comment
There was a problem hiding this comment.
I did not test but this looks good!
Repiteo
force-pushed
the
core/to-from-native
branch
from
d53a952 to
b802229
Compare
dsnopek
approved these changes
Oct 29, 2025
Ivorforce
approved these changes
Oct 29, 2025
Member
Ivorforce
left a comment
Ivorforce
left a comment
There was a problem hiding this comment.
Discussed in the last core meeting. This is a fix for bug in a supported feature that just wasn't considered in the original implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the interest of minimality, this integrates a fix as a hardcoded override for the
to_native()function. An alternative implementation would be expandingbuilt_in_strtodto recognizeINF/NAN, which would be MUCH faster but risks subtle bugs basically everywhere