Fix Input.is_joy_known response for SDL joypads#111503
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Nov 12, 2025
Merged
Fix Input.is_joy_known response for SDL joypads#111503Repiteo merged 1 commit intogodotengine:masterfrom
Input.is_joy_known response for SDL joypads#111503Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
AThousandShips
changed the title
Input.is_joy_known response for SDL joypads
JestemStefan
force-pushed
the
fix_111176
branch
from
f78fb1e to
d769633
Compare
Nintorch
reviewed
Oct 11, 2025
Nintorch
reviewed
Oct 11, 2025
Contributor
|
Otherwise I think it looks good! :) |
JestemStefan
force-pushed
the
fix_111176
branch
from
d769633 to
798efab
Compare
JestemStefan
force-pushed
the
fix_111176
branch
from
798efab to
479cc51
Compare
Contributor
Author
|
I pushed and update with condition added as mentioned earlier. Let me know if this is fine |
Nintorch
reviewed
Oct 12, 2025
JestemStefan
force-pushed
the
fix_111176
branch
from
479cc51 to
2a4de1a
Compare
bruvzg
approved these changes
Oct 28, 2025
akien-mga
approved these changes
Nov 4, 2025
akien-mga
added
the
cherrypick:4.5
JestemStefan
force-pushed
the
fix_111176
branch
from
2a4de1a to
3f98a54
Compare
Contributor
|
Thanks! |
Member
|
Cherry-picked for 4.5.2. |
akien-mga
removed
the
cherrypick:4.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #111176
I added a wrappedSDL_IsGamepadcall in JoypadSDLis_knownmethod as suggested by @Nintorch.Later I call this method in
Input.is_joy_knownwhen SDL is enabled.EDIT: I exposed new boolean on Joypad class called
is_knownthat is checked inInput.is_joy_knownmethod.This variable is set during handling of
Input.joy_connection_changedbased on the joy_infomapping_handledparam. This param value is set totrueif SDL is recognizing gamepad during connection eventI hope I did it right. Let me know if there are any things I should change.
Not my first contribution, but I'm still a beginner.