Merged
Conversation
Member
Author
|
This should fix this particular case but finishing building the full template to confirm on Windows at least Edit: It solves it on Windows fully |
akien-mga
approved these changes
Oct 10, 2025
Ivorforce
approved these changes
Oct 11, 2025
Member
Author
|
In the future I can try to build especially risky PRs locally and identify potential problems if people are unable to do them themselves due to capacity, my computer does them reasonably fast when I have a cache that's reasonably fresh I've transitioned to build on a server recently and for that I can't build PRs easily but I can do it locally for testing |
Member
Author
|
Can we get this merged? |
Contributor
|
Catching up on the merge queue as we speak, so it should be integrated shortly! |
Contributor
|
Thanks! |
Member
Author
|
Thank you! Can build my templates again 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the repeated broken builds on either debug or 2D disabled or both I think anyone doing major reworks of include hierarchy etc. should definitely do due diligence and compile 2D only templates to make sure this doesn't happen, again
Regression from:
node.h#111405Other recent cases:
is_classwithderives_from." #110892