Remove circular unneeded debug_adapter_protocol.h include from debug_adapter_parser.h#111470
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 10, 2025
Merged
Conversation
akien-mga
reviewed
Oct 10, 2025
Ivorforce
changed the title
debug_adapter_protocol.h include from `debug_adapter_parser.hdebug_adapter_protocol.h include from debug_adapter_parser.h
Ivorforce
force-pushed
the
debug-circular-include
branch
from
8cf5ff3 to
0c85d9b
Compare
akien-mga
approved these changes
Oct 10, 2025
…ug_adapter_parser.h`.
Ivorforce
force-pushed
the
debug-circular-include
branch
from
0c85d9b to
56abd0e
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
debug_adapter_protocol.hincludesdebug_adapter_parser.h, anddebug_adapter_parser.hincludesdebug_adapter_protocol.h. This can break builds in casedebug_adapter_parser.his included first, because the following would happen:debug_adapter_parser.hstarts to parsedebug_adapter_protocol.hfounddebug_adapter_protocol.hstarts to parsedebug_adapter_parser.hfound, but ignoredRemoteDebuggerfails to resolve (usually included throughdebug_adapter_parser.h)Turns out neither of these actually needs to include the other, so I simplified the includes.