Ensure XrRenderModelPropertiesEXT::type is initialized #111434
Ensure XrRenderModelPropertiesEXT::type is initialized #111434Repiteo merged 1 commit intogodotengine:masterfrom
XrRenderModelPropertiesEXT::type is initialized #111434Conversation
ChristophHaag
force-pushed
the
initialize_XrRenderModelPropertiesEXT_type
branch
from
316d93a to
fdb785a
Compare
AThousandShips
changed the title
XrRenderModelPropertiesEXT::type is initialized
devloglogan
left a comment
devloglogan
left a comment
There was a problem hiding this comment.
Please update this so it follows the braced initialization format like the rest of this file, see the properties_info initialization immediately above.
So something like
XrRenderModelPropertiesEXT properties = {
XR_TYPE_RENDER_MODEL_PROPERTIES_EXT, // type
nullptr, // next
};
|
I had that first, but mac ci complained that the whole struct needs to be initialized with this syntax so it would be XrRenderModelPropertiesEXT properties = {
XR_TYPE_RENDER_MODEL_PROPERTIES_EXT,
nullptr,
{},
false,
};even though only typed and next need to actually be initialized, the rest is (over)written by the runtime. Should I change it to that? |
|
Huh, I didn't realize CI had that restriction! I personally would still change it to that though since that's the standard, including the variable names in the comments. And I'd put a |
ChristophHaag
force-pushed
the
initialize_XrRenderModelPropertiesEXT_type
branch
from
fdb785a to
e33e069
Compare
dsnopek
left a comment
dsnopek
left a comment
There was a problem hiding this comment.
Thanks! Looks good to me :-)
|
Thanks! Congratulations on your first merged contribution! 🎉 |
5 participants
No description provided.