MacOS: Improve crash handler performance#111425
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 9, 2025
Merged
Conversation
The most significant change is the version calls `atos` with a batch of addresses, rather than one at a time. Reduces large stack traces down to about a second or less (after OS caching).
bruvzg
approved these changes
Oct 9, 2025
Member
bruvzg
left a comment
bruvzg
left a comment
There was a problem hiding this comment.
Seems to be working as expected. And an order of magnitude faster than old implementation.
akien-mga
approved these changes
Oct 9, 2025
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve performance of crash output
The most significant change is the version calls
atoswith a batch of addresses, rather than one at a time. Reduces large stack traces down to about a second or less (after OS caching).