Remove compositor.h include from world_3d.h.#111402
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 8, 2025
Merged
Remove compositor.h include from world_3d.h.#111402Repiteo merged 1 commit intogodotengine:masterfrom
compositor.h include from world_3d.h.#111402Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
Ivorforce
force-pushed
the
world-3d-no-compositor
branch
from
af940d7 to
347302b
Compare
Ivorforce
force-pushed
the
world-3d-no-compositor
branch
from
347302b to
207e8c1
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've profiled a random compile unit (
audio_stream_editor_plugin.json). As aNode3Dinheritor (which is somewhat common), it includes an include path toworld_3d.h. I initially tried to remove theworld_3d.hinclude, but it turns out, mostNode3Dmake active use of it.world_3d.h's build cost is mostly caused bycompositor.h, which can be more easily removed. It accounts for 10% of total build time in this compile unit, throughrender_data.h>render_scene_data.h>script_language.h>doc_data.h.