Only include hash_set.h and safe_refcount.h in object.h when used.#111371
Open
chocola-mint wants to merge 1 commit intogodotengine:masterfrom
Open
Only include hash_set.h and safe_refcount.h in object.h when used.#111371chocola-mint wants to merge 1 commit intogodotengine:masterfrom
hash_set.h and safe_refcount.h in object.h when used.#111371chocola-mint wants to merge 1 commit intogodotengine:masterfrom
Conversation
Member
|
This would need to be tested with a few different compile configurations to avoid cases like: |
chocola-mint
force-pushed
the
object-conditional-includes
branch
from
205ddde to
6582b1f
Compare
Member
|
This makes sense in principle, but I think it might end up being a source of frustration for contributors. Most contributors build the editor (both I don't think slightly reducing the incremental recompilation time of templates is worth that development time hassle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #111218
hash_set.handsafe_refcount.hare only used in editor builds and debug builds respectively. This PR makes it so their headers aren't unnecessarily included and should improve compilation times for release builds.