X Tutup
Skip to content

[Windows] Fix MinGW build#111368

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
AThousandShips:fix_build_win
Oct 7, 2025
Merged

[Windows] Fix MinGW build#111368
Repiteo merged 1 commit intogodotengine:masterfrom
AThousandShips:fix_build_win

Conversation

@AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Oct 7, 2025

file_access.h was removed from the include hierarchy and wasn't caught by CI as it only occurs with MinGW builds

Unsure if this affects any other area not caught by CI, but this was the one I ran across myself and could confirm

Regression from:

@AThousandShips
[Windows] Fix MinGW build
f81f08e 
`file_access.h` was removed from the include hierarchy and wasn't caught
by CI as it only occurs with MinGW builds
@AThousandShips AThousandShips added this to the 4.6 milestone Oct 7, 2025
@AThousandShips AThousandShips requested a review from a team as a code owner October 7, 2025 14:09
@AThousandShips AThousandShips requested a review from a team October 7, 2025 14:10
@TokageItLab
Copy link
Member

TokageItLab commented Oct 7, 2025 •
edited
Loading

I wonder why #111274 passed the CI test in the first place. Is there some kind of missing line for MinGW in the CI yaml?

@AThousandShips
Copy link
Member Author

AThousandShips commented Oct 7, 2025 •
edited
Loading

The crash handler is only built on DEBUG_ENABLED builds, CI only builds a release template with MinGW

@AThousandShips AThousandShips mentioned this pull request Oct 7, 2025
Open
@Repiteo Repiteo merged commit e3c64cf into godotengine:master Oct 7, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 7, 2025

Thanks!

@AThousandShips AThousandShips deleted the fix_build_win branch October 7, 2025 18:44
@AThousandShips
Copy link
Member Author

AThousandShips commented Oct 7, 2025

Thank you!

@AThousandShips AThousandShips mentioned this pull request Oct 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ivorforce Ivorforce Ivorforce approved these changes

@TokageItLab TokageItLab TokageItLab approved these changes

Assignees

No one assigned

Labels

bug platform:windows regression topic:buildsystem

Projects

None yet

Milestone

4.6

Development

Successfully merging this pull request may close these issues.

4 participants

@AThousandShips @TokageItLab @Repiteo @Ivorforce
X Tutup