X Tutup
Skip to content

Add relative option to LookAt/AimModifier3D#111367

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
TokageItLab:relative-look-at
Nov 17, 2025
Merged

Add relative option to LookAt/AimModifier3D#111367
Repiteo merged 1 commit intogodotengine:masterfrom
TokageItLab:relative-look-at

Conversation

@TokageItLab
Copy link
Member

Add a relative option to make Aim/LookAt rotate after other Modifier rotations. This is useful when you want to handle only Twist after some modifiers processed.

raim.mp4

The default is set to false for compatibility, but since it's likely true in most cases, it might be acceptable to set the default to true.

@TokageItLab TokageItLab added this to the 4.6 milestone Oct 7, 2025
@TokageItLab TokageItLab requested review from a team as code owners October 7, 2025 14:05
@TokageItLab TokageItLab force-pushed the relative-look-at branch 2 times, most recently from 91d5633 to a0fef2a Compare October 7, 2025 18:15
@TokageItLab TokageItLab requested review from a team as code owners October 7, 2025 18:15
@TokageItLab TokageItLab requested a review from a team October 7, 2025 18:15
@TokageItLab TokageItLab requested a review from a team as a code owner October 7, 2025 18:15
@TokageItLab TokageItLab requested a review from a team October 7, 2025 18:15
@TokageItLab TokageItLab force-pushed the relative-look-at branch 4 times, most recently from 383c605 to fc62be2 Compare October 14, 2025 12:41
@TokageItLab TokageItLab force-pushed the relative-look-at branch 3 times, most recently from 8edf494 to c0c61a2 Compare October 31, 2025 23:44
@TokageItLab TokageItLab force-pushed the relative-look-at branch 3 times, most recently from 315b69a to eb8e068 Compare November 3, 2025 17:54
@TokageItLab TokageItLab requested a review from a team as a code owner November 3, 2025 17:54
Copy link
Contributor

@lyuma lyuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in the animation meeting.

We had a question if we should change the default to relative true which may have some compatibility impact in rare cases but may be more intuitive

@TokageItLab
Copy link
Member Author

I added the breaks compat label because the default behavior has changed.

The old behavior, which completely replaced that pose, was essentially a bug. However, there is a migration path for those who depend on the old behavior: set the option to false.

Copy link
Contributor

@lyuma lyuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in animation meeting

@TokageItLab TokageItLab moved this to Approved, Waiting for Production in Animation Team Issue Triage Nov 14, 2025
@Repiteo Repiteo merged commit c5ebb7a into godotengine:master Nov 17, 2025
20 checks passed
@github-project-automation github-project-automation bot moved this from Approved, Waiting for Production to Done in Animation Team Issue Triage Nov 17, 2025
@Repiteo
Copy link
Contributor

Repiteo commented Nov 17, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup