Scons: Remove system includes#111346
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 7, 2025
Merged
Conversation
Repiteo
force-pushed
the
scons/remove-system-includes
branch
from
bb08e71 to
4b5d702
Compare
Repiteo
force-pushed
the
scons/remove-system-includes
branch
from
4b5d702 to
b950247
Compare
akien-mga
reviewed
Oct 7, 2025
Comment on lines
839
to
+840
| #ifndef __EMSCRIPTEN__ | ||
| #ifdef __GNUC__ | ||
| #if defined(__GNUC__) && !defined(__clang__) |
Member
There was a problem hiding this comment.
I'm surprised that it's not a problem upstream, they must support compiling with Clang.
It seems like the #ifndef __EMSCRIPTEN__ here is meant to prevent adding these pragma too, so it could be dropped (and the change PR'ed upstream) as __clang__ is defined for Emscripten too.
akien-mga
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CPPEXTPATHfor external includes" #111331Implements the removal of system includes mentioned in the above PR, which will guarantee their include chains are properly tracked when building