Improve type registration order in register_core_types.cpp.#111318
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 7, 2025
Merged
Improve type registration order in register_core_types.cpp.#111318Repiteo merged 1 commit intogodotengine:masterfrom
register_core_types.cpp.#111318Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
dsnopek
approved these changes
Oct 6, 2025
Contributor
dsnopek
left a comment
dsnopek
left a comment
There was a problem hiding this comment.
Thanks! These changes look good to me. I'm actually surprised at how minimal the changes are for the core types - I had thought the situation was much worse :-)
Member
Author
There are a bunch more, but most of the rest isn't as straight forward. I'm just taking it slow 😅 |
Repiteo
changed the title
register_core_types.cpp.
Repiteo
approved these changes
Oct 7, 2025
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our main setup, types are being registered out of order. This denies us from making confident caches, because the parent may not be fully registered by the time the child is registered.
This PR is a first, small step towards making them ordered. This prepares for the eventual merge of #106873, by reducing the number of warnings it would raise.
Since there will be a handful of PRs like this, I'll try to keep them thematically consistent, to make review easier.