Remove unused members from Viewport#111304
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 7, 2025
Merged
Conversation
Ivorforce
approved these changes
Oct 5, 2025
Member
Ivorforce
left a comment
Ivorforce
left a comment
There was a problem hiding this comment.
If it compiles, it should be good. It's always a mystery to me though how the last users of some property are removed without the property being removed alongside.
Member
Author
|
Probably people removing stuff are not always aware that they are removing the last user. Not sure if there is a way to catch this automatically |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gen_mipmapsseems to be a relic from Godot 2: https://docs.godotengine.org/en/2.1/classes/class_viewport.html#class-viewport-set-render-target-gen-mipmapslast_vp_rect, but blame points to e82dc40