X Tutup
Skip to content

Unix: Don't print an error if bind fails#111300

Merged
akien-mga merged 1 commit intogodotengine:masterfrom
stuartcarnie:net_unix_error_spam
Oct 6, 2025
Merged

Unix: Don't print an error if bind fails#111300
akien-mga merged 1 commit intogodotengine:masterfrom
stuartcarnie:net_unix_error_spam

Conversation

@stuartcarnie
Copy link
Contributor

Summary

Remove unnecessary ERR_COND_FAIL_V check, as the remainder of the function only returns the value.

Partially addresses #111261; as Godot should also consider not trying to bind the port every frame.

@stuartcarnie stuartcarnie requested a review from a team as a code owner October 5, 2025 19:14
@bruvzg bruvzg added this to the 4.6 milestone Oct 5, 2025
@akien-mga akien-mga added the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Oct 5, 2025
@stuartcarnie
Copy link
Contributor Author

Note

These changes were only in 4.6

@akien-mga akien-mga removed the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Oct 5, 2025
@akien-mga akien-mga merged commit 1043c3f into godotengine:master Oct 6, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@stuartcarnie stuartcarnie deleted the net_unix_error_spam branch October 6, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup