Fix GDScript translation parser for FileDialog.add_filter() two-parameter format#111298
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 8, 2025
Onebit5:fix-filedialog-translation-parser
Merged
Fix GDScript translation parser for FileDialog.add_filter() two-parameter format#111298Repiteo merged 1 commit intogodotengine:masterfrom Onebit5:fix-filedialog-translation-parser
FileDialog.add_filter() two-parameter format#111298Repiteo merged 1 commit intogodotengine:masterfrom
Onebit5:fix-filedialog-translation-parser
Conversation
dalexeev
reviewed
Oct 6, 2025
dalexeev
approved these changes
Oct 8, 2025
Member
|
Also please squash your commits into one. |
Contributor
Author
|
All commits squashed into one. |
Member
|
Please edit your commit message. It looks uninformative (all previous commit titles). Also, it seems GitHub doesn't take 
|
…eter format The parser only handled the single-parameter semicolon format and thew an error with two-parameter format. This fix supports both formats. Co-authored-by: Danil Alexeev <dalexeev12@yandex.ru>
Contributor
Author
|
Commit message updated with description and |
Contributor
|
Thanks! |
akien-mga
changed the title
FileDialog.add_filter() two-parameter format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: GDScript translation parser bug with FileDialog #111286
The translation parser was only handling the single-parameter format of
add_filter("*.jpg; JPE Images")and would throw an error when you used the two-parameter formatadd_filter("*.jpg", "JPE Images").This fix checks for the second parameter first before trying to parse the semicolon format, so both ways work now, and translatable filter names get extracted properly.