X Tutup
Skip to content

Android Editor: Add game speed control options in game menu bar#111296

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
syntaxerror247:speed-control
Oct 21, 2025
Merged

Android Editor: Add game speed control options in game menu bar#111296
Repiteo merged 1 commit intogodotengine:masterfrom
syntaxerror247:speed-control

Conversation

@syntaxerror247
Copy link
Member

@syntaxerror247 syntaxerror247 commented Oct 5, 2025

Adds speed control options to the embedded game window for the Android Editor.

Screenrecorder-2025-10-12-12-11-33-855.mp4

@syntaxerror247 syntaxerror247 requested review from a team as code owners October 5, 2025 17:56
@syntaxerror247 syntaxerror247 requested review from a team and removed request for a team October 5, 2025 17:56
@syntaxerror247 syntaxerror247 added this to the 4.6 milestone Oct 5, 2025
@syntaxerror247 syntaxerror247 marked this pull request as draft October 5, 2025 18:34
@syntaxerror247 syntaxerror247 marked this pull request as ready for review October 7, 2025 19:54
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good! Can you provide a recording showing the added functionality.

@syntaxerror247
Copy link
Member Author

@m4gr3d, Attached the video in PR description.

@m4gr3d
Copy link
Contributor

m4gr3d commented Oct 12, 2025

@m4gr3d, Attached the video in PR description.

Thanks!

I'm slightly concerned by the fact that the addition of these menus make the rest of the options not visible, which requires the user to have to scroll to see them.
Could we instead move the new options to the drop down menu that's shown when pressing the three vertical dots, or does that go against the layout for the desktop version of the editor?

@syntaxerror247
Copy link
Member Author

I'm slightly concerned by the fact that the addition of these menus make the rest of the options not visible, which requires the user to have to scroll to see them. Could we instead move the new options to the drop down menu that's shown when pressing the three vertical dots, or does that go against the layout for the desktop version of the editor?

I share the concern but I don’t think putting these under the dropdown menu is the right move, and it does go against the desktop version too. Even if we hide them now, the same issue will pop up again once window resizing functionality is implemented.

Scrolling like this is also pretty common in Android apps. I'd say let’s go ahead with this ;)

@m4gr3d
Copy link
Contributor

m4gr3d commented Oct 16, 2025

I'm slightly concerned by the fact that the addition of these menus make the rest of the options not visible, which requires the user to have to scroll to see them. Could we instead move the new options to the drop down menu that's shown when pressing the three vertical dots, or does that go against the layout for the desktop version of the editor?

I share the concern but I don’t think putting these under the dropdown menu is the right move, and it does go against the desktop version too. Even if we hide them now, the same issue will pop up again once window resizing functionality is implemented.

Scrolling like this is also pretty common in Android apps. I'd say let’s go ahead with this ;)

Sounds good.

Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Repiteo Repiteo merged commit e6eb498 into godotengine:master Oct 21, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 21, 2025

Thanks!

@syntaxerror247 syntaxerror247 deleted the speed-control branch October 21, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup