Store ThemeOwner owner directly as Node*#111249
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 7, 2025
Merged
Conversation
KoBeWi
reviewed
Oct 4, 2025
HolonProduction
force-pushed
the
owner-node
branch
from
e9b31a4 to
a5d19f7
Compare
KoBeWi
approved these changes
Oct 4, 2025
HolonProduction
force-pushed
the
owner-node
branch
from
a5d19f7 to
db9a0d8
Compare
Member
Author
|
Added a fix to the check, to allow |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment
ThemeOwnerstores its owner node casted to eitherControlorWindow. Those casted pointers are never really used and all public methods just useNode *so we can store the pointer directly without casting.Main benefit is just to remove some noise from the code. I was looking a bit into the theming system and it took me way to long to realize that those methods and members don't really do anything relevant.