Expose is_valid() from AnimationPlayer to make detecting paused animations possible.#111178
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 7, 2025
Merged
Expose is_valid() from AnimationPlayer to make detecting paused animations possible.#111178Repiteo merged 1 commit intogodotengine:masterfrom
is_valid() from AnimationPlayer to make detecting paused animations possible.#111178Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
Calinou
reviewed
Oct 2, 2025
Calinou
reviewed
Oct 2, 2025
Member
Calinou
left a comment
Calinou
left a comment
There was a problem hiding this comment.
Tested locally, it works as expected.
TokageItLab
requested changes
Oct 2, 2025
TokageItLab
requested changes
Oct 2, 2025
PhairZ
changed the title
is_paused() to AnimationPlayeris_valid() from AnimationPlayer to make detecting paused animations possible.
TokageItLab
approved these changes
Oct 3, 2025
Member
TokageItLab
left a comment
TokageItLab
left a comment
There was a problem hiding this comment.
Implementation is fine. I think we can discuss naming and documentation with other maintainers. cc @Mickeon @AThousandShips
TokageItLab
approved these changes
Oct 3, 2025
TokageItLab
moved this to Approved, Waiting for Production
in Animation Team Issue Triage
github-project-automation
bot
moved this from Approved, Waiting for Production
to Done
in Animation Team Issue Triage
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes godotengine/godot-proposals#13208