Remove side menu functionality in EditorFileDialog#111162
Remove side menu functionality in EditorFileDialog#111162Repiteo merged 1 commit intogodotengine:masterfrom
EditorFileDialog#111162Conversation
0201ddb to
76d22af
Compare
|
This is a breaking change and isn't deprecation, deprecation keeps the behavior and just marks it as deprecated |
76d22af to
c645e69
Compare
|
I would be better to keep the new dialog and and just tag the method as deprecated. |
|
I can't just deprecate the method. If the dialogs are going to be merged, either FileDialog needs this functionality, or EditorFileDialog needs it removed. With the way I plan to do the merging, leaving side menu only in EditorFileDialog will require some hacks. |
|
Then that should be part of the discussion, but regardless the descriptions and the naming should be updated to reflect that the method was removed rather than deprecated |
Checkboxes and option boxes are supported by native dialogs, but adding fully custom elements like this is completely impossible (it's not a limitation of the current implementation, it will never work). |
This is the current state. If native dialog is used, and side menu is set, it pops up as a separate dialog before file selector is shown. |
c645e69 to
a03e56d
Compare
|
I changed the config dialog to appear after selecting file: godot.windows.editor.dev.x86_64_OEJBQBGwUw.mp4It's more consistent with other software. |
aaronfranke
left a comment
There was a problem hiding this comment.
I'm sad to see this go entirely instead of the solution I suggested. But anyway, I understand why, and I won't block this. The code looks good to me.
bruvzg
left a comment
There was a problem hiding this comment.
It should provide a uniform experience on all platforms. And one extra click is not a big issue.
EditorFileDialog
a03e56d to
33ccc51
Compare
|
Thanks! |

Alternative to #111120
This deprecates
add_side_menu()and replaces the only usage with an additional dialog.godot.windows.editor.dev.x86_64_POibzZ9HIU.mp4
It's similar to what was already happening when native dialogs were enabled, but the config dialog is more compact.