X Tutup
Skip to content

Remove side menu functionality in EditorFileDialog#111162

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
KoBeWi:tfw_your_side_projects_goes_to_trash
Oct 22, 2025
Merged

Remove side menu functionality in EditorFileDialog#111162
Repiteo merged 1 commit intogodotengine:masterfrom
KoBeWi:tfw_your_side_projects_goes_to_trash

Conversation

@KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Oct 2, 2025

Alternative to #111120
This deprecates add_side_menu() and replaces the only usage with an additional dialog.

godot.windows.editor.dev.x86_64_POibzZ9HIU.mp4

It's similar to what was already happening when native dialogs were enabled, but the config dialog is more compact.

@KoBeWi KoBeWi added this to the 4.6 milestone Oct 2, 2025
@KoBeWi KoBeWi requested review from a team as code owners October 2, 2025 12:05
@KoBeWi KoBeWi requested a review from aaronfranke October 2, 2025 12:05
@KoBeWi KoBeWi force-pushed the tfw_your_side_projects_goes_to_trash branch from 0201ddb to 76d22af Compare October 2, 2025 13:40
@AThousandShips
Copy link
Member

This is a breaking change and isn't deprecation, deprecation keeps the behavior and just marks it as deprecated

@KoBeWi KoBeWi force-pushed the tfw_your_side_projects_goes_to_trash branch from 76d22af to c645e69 Compare October 2, 2025 13:49
@YeldhamDev
Copy link
Member

I would be better to keep the new dialog and and just tag the method as deprecated.

@KoBeWi
Copy link
Member Author

KoBeWi commented Oct 2, 2025

I can't just deprecate the method. If the dialogs are going to be merged, either FileDialog needs this functionality, or EditorFileDialog needs it removed. With the way I plan to do the merging, leaving side menu only in EditorFileDialog will require some hacks.

@AThousandShips
Copy link
Member

Then that should be part of the discussion, but regardless the descriptions and the naming should be updated to reflect that the method was removed rather than deprecated

@aaronfranke
Copy link
Member

aaronfranke commented Oct 2, 2025

This was designed for parity with Blender: Screenshot 2023-07-11 at 12 50 53 AM

As for only being used by glTF... well, so far. There are other places (I don't remember where off hand) in the editor dialogs that add checkboxes to the bottom of the dialog, which IMO should be migrated to the side menu. Regardless, we would need to do something with those checkboxes with native dialogs.

I would prefer to keep this feature, and perhaps we need to dynamically make it behave like it looks in this PR when native dialogs are enabled, perhaps by making the file dialog hide most of its UI and contain a native dialog showing button instead of the save button. So essentially, FileDialog would "contain" a native file dialog, and go directly to it when using the native dialog AND there is no side menu, but otherwise it would show its own UI.

@bruvzg
Copy link
Member

bruvzg commented Oct 7, 2025

Regardless, we would need to do something with those checkboxes with native dialogs.

Checkboxes and option boxes are supported by native dialogs, but adding fully custom elements like this is completely impossible (it's not a limitation of the current implementation, it will never work).

@bruvzg
Copy link
Member

bruvzg commented Oct 7, 2025

I would prefer to keep this feature, and perhaps we need to dynamically make it behave like it looks in this PR when native dialogs are enabled, perhaps by making the file dialog hide most of its UI and contain a native dialog showing button instead of the save button.

This is the current state. If native dialog is used, and side menu is set, it pops up as a separate dialog before file selector is shown.

@KoBeWi KoBeWi force-pushed the tfw_your_side_projects_goes_to_trash branch from c645e69 to a03e56d Compare October 21, 2025 12:29
@KoBeWi
Copy link
Member Author

KoBeWi commented Oct 21, 2025

I changed the config dialog to appear after selecting file:

godot.windows.editor.dev.x86_64_OEJBQBGwUw.mp4

It's more consistent with other software.

Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sad to see this go entirely instead of the solution I suggested. But anyway, I understand why, and I won't block this. The code looks good to me.

Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should provide a uniform experience on all platforms. And one extra click is not a big issue.

@AThousandShips AThousandShips changed the title Deprecate side menu in EditorFileDialog Remove side menu functionality in EditorFileDialog Oct 22, 2025
@KoBeWi KoBeWi force-pushed the tfw_your_side_projects_goes_to_trash branch from a03e56d to 33ccc51 Compare October 22, 2025 10:29
@Repiteo Repiteo merged commit 0d85d43 into godotengine:master Oct 22, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 22, 2025

Thanks!

@KoBeWi KoBeWi deleted the tfw_your_side_projects_goes_to_trash branch October 22, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

X Tutup